ns16550: fix an incorrect assignment to uart->io_size
authorAyan Kumar Halder <ayan.kumar.halder@amd.com>
Tue, 7 Feb 2023 16:00:47 +0000 (17:00 +0100)
committerJan Beulich <jbeulich@suse.com>
Tue, 7 Feb 2023 16:00:47 +0000 (17:00 +0100)
uart->io_size represents the size in bytes. Thus, when serial_port.bit_width
is assigned to it, it should be converted to size in bytes.

Fixes: 17b516196c ("ns16550: add ACPI support for ARM only")
Reported-by: Jan Beulich <jbeulich@suse.com>
Signed-off-by: Ayan Kumar Halder <ayan.kumar.halder@amd.com>
Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>
master commit: 352c89f72ddb67b8d9d4e492203f8c77f85c8df1
master date: 2023-01-24 16:54:38 +0100

xen/drivers/char/ns16550.c

index 01a05c9aa859a76354ef14c7f196347609bd1913..ce013fb6a55732b312338104f1c9548a14a115f7 100644 (file)
@@ -1875,7 +1875,7 @@ static int __init ns16550_acpi_uart_init(const void *data)
     uart->parity = spcr->parity;
     uart->stop_bits = spcr->stop_bits;
     uart->io_base = spcr->serial_port.address;
-    uart->io_size = spcr->serial_port.bit_width;
+    uart->io_size = DIV_ROUND_UP(spcr->serial_port.bit_width, BITS_PER_BYTE);
     uart->reg_shift = spcr->serial_port.bit_offset;
     uart->reg_width = spcr->serial_port.access_width;